Fix setup script for RedHat based Linux #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use rpm= packages passed to install with yum. Recognise yum in check-for-build-tools
Unused anywhere in this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/setupseems to have a partial implementation for RedHat based Linux distributions (i.e. those using RPM packages).This completes what is there and as a side note drops the seemingly unused
herokurequirement.rpm=...packages withyumyumas a package managerherokuPlease note: I am not using a RedHat based Linux at the moment but have tested this out in a docker image for fedora:31 using rbenv to build ruby 2.6.5.
Yum seems to be currently available in notable RPM distros:
dnfin favour ofyumbutyumstill seems to be available there.yum