Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

VS2013 project files: not loading common controls #147

Closed
FauxFaux opened this issue Apr 6, 2014 · 4 comments
Closed

VS2013 project files: not loading common controls #147

FauxFaux opened this issue Apr 6, 2014 · 4 comments

Comments

@FauxFaux
Copy link
Owner

FauxFaux commented Apr 6, 2014

i.e. ugly-ass crap in the debugger.

The putty.rc is there, and the flags are probably right.

@NAW77
Copy link

NAW77 commented Apr 16, 2014

Hi Chris
I wanted to compile the code from github under VS2013 as well but it would not work. So I went back to my version of the hanstree Putty Tray build 0.62-13 as I had converted the original MSVC files by hand. It compiled after upgrading in VS2013.

After some work I now have PSCP and PUTTY MSVC projects converted for your branch.
When you open them in Visual Studio it upgrades the project and then builds without error.
I am still working on changing the other suite files (should be done soon).

I can pass these files on if you would like them, the generated vcxproject and filter files may be of help to you as well?

Nick

@ghost
Copy link

ghost commented May 16, 2014

Is this related?

    \PuTTYTray\windows\MSVC2010\pscp\pscp.vcxproj : error  : The item "..\..\pscp.rc" already exists under the filter "".

    \PuTTYTray\windows\MSVC2010\psftp\psftp.vcxproj : error  : The item "..\..\psftp.rc" already exists under the filter "".

    \PuTTYTray\windows\MSVC2010\plink\plink.vcxproj : error  : The item "..\..\plink.rc" already exists under the filter "".

    \PuTTYTray\windows\MSVC2010\putty\putty.vcxproj : error  : The item "..\..\putty.rc" already exists under the filter "".

Patched simply by:

From 58d4c3b0625e479a4158ca7acc07001c4b582acd Mon Sep 17 00:00:00 2001
From: Adam Baxter <voltagex@voltagex.org>
Date: Fri, 16 May 2014 23:06:17 +1000
Subject: [PATCH] Hack project files to open correctly in VS2013

---
 windows/MSVC2010/plink/plink.vcxproj | 1 -
 windows/MSVC2010/pscp/pscp.vcxproj   | 1 -
 windows/MSVC2010/psftp/psftp.vcxproj | 1 -
 windows/MSVC2010/putty/putty.vcxproj | 1 -
 4 files changed, 4 deletions(-)

diff --git a/windows/MSVC2010/plink/plink.vcxproj b/windows/MSVC2010/plink/plink.vcxproj
index 591ad44..a6b6691 100644
--- a/windows/MSVC2010/plink/plink.vcxproj
+++ b/windows/MSVC2010/plink/plink.vcxproj
@@ -99,7 +99,6 @@
     <ClInclude Include="..\..\..\windows\winstuff.h" />
   </ItemGroup>
   <ItemGroup>
-    <None Include="..\..\..\windows\plink.rc" />
     <None Include="..\..\..\windows\putty.ico" />
   </ItemGroup>
   <ItemGroup>
diff --git a/windows/MSVC2010/pscp/pscp.vcxproj b/windows/MSVC2010/pscp/pscp.vcxproj
index 9dd5e4c..1ae55a4 100644
--- a/windows/MSVC2010/pscp/pscp.vcxproj
+++ b/windows/MSVC2010/pscp/pscp.vcxproj
@@ -95,7 +95,6 @@
   </ItemGroup>
   <ItemGroup>
     <None Include="..\..\..\windows\pscp.ico" />
-    <None Include="..\..\..\windows\pscp.rc" />
   </ItemGroup>
   <ItemGroup>
     <ResourceCompile Include="..\..\pscp.rc" />
diff --git a/windows/MSVC2010/psftp/psftp.vcxproj b/windows/MSVC2010/psftp/psftp.vcxproj
index 7a5895f..54a2826 100644
--- a/windows/MSVC2010/psftp/psftp.vcxproj
+++ b/windows/MSVC2010/psftp/psftp.vcxproj
@@ -95,7 +95,6 @@
   </ItemGroup>
   <ItemGroup>
     <None Include="..\..\..\windows\pscp.ico" />
-    <None Include="..\..\..\windows\psftp.rc" />
   </ItemGroup>
   <ItemGroup>
     <ResourceCompile Include="..\..\psftp.rc" />
diff --git a/windows/MSVC2010/putty/putty.vcxproj b/windows/MSVC2010/putty/putty.vcxproj
index 6333dc7..e2b5d75 100644
--- a/windows/MSVC2010/putty/putty.vcxproj
+++ b/windows/MSVC2010/putty/putty.vcxproj
@@ -131,7 +131,6 @@
     <None Include="..\..\..\windows\pageant.ico" />
     <None Include="..\..\..\windows\pageant.rc" />
     <None Include="..\..\..\windows\putty.ico" />
-    <None Include="..\..\..\windows\putty.rc" />
     <None Include="..\..\..\windows\puttycfg.ico" />
     <None Include="..\..\..\windows\puttygen.ico" />
     <None Include="..\..\..\windows\puttygen.rc" />
-- 
1.9.2.msysgit.0


@mmozeiko
Copy link

For me this occurred when VS2013 enabled its own manifest embedding in linker. putty.mft file that enabled proper common controls was also embedded in exe, but was not used (default manifest was overriding it). I disabled default manifest in Project Properties -> Linker -> Manifest File -> Generate Manifest = NO. After that proper common controls were loaded and putty was pretty again.

@FauxFaux
Copy link
Owner Author

VS2013 is comically long gone. Viva la VS2017!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants