Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome 45 #47

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Gnome 45 #47

merged 7 commits into from
Oct 25, 2023

Conversation

Favo02
Copy link
Owner

@Favo02 Favo02 commented Oct 25, 2023

  • port extension to GNOME 45 (breaking change) Porting to GNOME 45 #39
  • refactor code style (camelcase, () => vs function, const usage)

@Favo02 Favo02 merged commit 71f37f2 into main Oct 25, 2023
@Favo02 Favo02 deleted the gnome-45 branch October 25, 2023 21:53
@maxborn
Copy link

maxborn commented Oct 26, 2023

Hi Luca, thanks for the update. Unforutnatelly, version 9 didn't worked on my system. I'm using Alma 9, which comes with Gnome 40. The error on my system was this


Stack trace:
  @/home/user_name/.local/share/gnome-shell/extensions/workspaces-by-open-apps@favo02.github.com/prefs.js:1:32
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:216:33
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:128:33
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

I made sure all the awd packages available for my system were installed, and still same problem.
For the time beein I went back to version 8. Not a problem, but it will be nice to have the new features working.
Thanks again for this wonderful extension, and your hard work.
Cheers.
Max.

@Favo02 Favo02 mentioned this pull request Oct 28, 2023
@Favo02
Copy link
Owner Author

Favo02 commented Oct 28, 2023

Sorry for the late reply, I didn't expect a report in a Pull Request 😅, please next time create a new Issue.

I created an issue (#53) referencing this, please use the issue to continue this discussion (so that I receive notifications).

I already released a new update (v11 #50), let me know if it solves the problem, otherwise I will have to investigate a little bit.

And thanks again for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants