Lock v8 Isolate while pumping message loop

Not sure when this became required. Docs do say > The caller has to make sure that this is called from the right thread. but make no mention of required locking.
Fayti1703 · Jun 1, 2023 · 1e43a49 · 1e43a49
1 parent 5663f5a
commit 1e43a49
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/ext/mini_racer_extension/mini_racer_extension.cc b/ext/mini_racer_extension/mini_racer_extension.cc
@@ -977,6 +977,8 @@ static VALUE rb_isolate_pump_message_loop(VALUE self) {
 
     if (current_platform == NULL) return Qfalse;
 
+    Locker guard { isolate_info->isolate };
+
     if (platform::PumpMessageLoop(current_platform.get(), isolate_info->isolate)){
 	return Qtrue;
     } else {