Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): missing CORS_ORIGIN env variable throws error #1385

Merged
merged 2 commits into from
Apr 3, 2023
Merged

fix(config): missing CORS_ORIGIN env variable throws error #1385

merged 2 commits into from
Apr 3, 2023

Conversation

NHS-juju
Copy link
Contributor

Issue resolved with optional chaining on the if statements.

@coveralls
Copy link

coveralls commented Mar 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4575735082

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 4572936666: 0.0%
Covered Lines: 1142
Relevant Lines: 1142
💛 - Coveralls

@Fdawgs Fdawgs changed the title Fix for https://github.com/Fdawgs/docsmith/issues/1384 fix(config): missing CORS_ORIGIN env variable throws error Apr 3, 2023
@Fdawgs Fdawgs linked an issue Apr 3, 2023 that may be closed by this pull request
Blank CORS_ORIGIN in .env does not default to false - crashes app instead. #1384
Closed
3 tasks
@Fdawgs Fdawgs merged commit dc34603 into Fdawgs:main Apr 3, 2023
@github-actions github-actions bot mentioned this pull request Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank CORS_ORIGIN in .env does not default to false - crashes app instead.
3 participants
@NHS-juju @coveralls @Fdawgs