Skip to content

Commit

Permalink
build(deps-dev): add eslint-community/eslint-plugin-eslint-comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Fdawgs committed Oct 8, 2023
1 parent 19a5838 commit 07641df
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
5 changes: 4 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module.exports = {
},
extends: [
"airbnb-base",
"plugin:@eslint-community/eslint-comments/recommended",
"plugin:jsdoc/recommended",
"plugin:promise/recommended",
"plugin:regexp/recommended",
Expand Down Expand Up @@ -49,10 +50,12 @@ module.exports = {
],
root: true,
rules: {
"@eslint-community/eslint-comments/disable-enable-pair": "off",
"@eslint-community/eslint-comments/no-unused-disable": "error",
"@eslint-community/eslint-comments/require-description": "error",
"import/no-extraneous-dependencies": "error",
"jsdoc/check-syntax": "error",
"jsdoc/require-hyphen-before-param-description": "error",
"no-console": "off",
"no-multiple-empty-lines": ["error", { max: 1 }],
"prefer-destructuring": ["error", { object: true, array: false }],
"promise/prefer-await-to-callbacks": "warn",
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
"devDependencies": {
"@commitlint/cli": "^17.7.1",
"@commitlint/config-conventional": "^17.7.0",
"@eslint-community/eslint-plugin-eslint-comments": "^4.1.0",
"@types/jest": "^29.5.5",
"eslint": "^8.50.0",
"eslint-config-airbnb-base": "^15.0.0",
Expand Down
3 changes: 0 additions & 3 deletions scripts/license-checker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/* eslint-disable security/detect-object-injection */
/* eslint-disable security-node/detect-crlf */

"use strict";

const { promisify } = require("node:util");
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function parseOptions(acceptedOptions, options, version) {
const invalidArgs = [];
Object.keys(options).forEach((key) => {
if (Object.hasOwn(acceptedOptions, key)) {
// eslint-disable-next-line valid-typeof
// eslint-disable-next-line valid-typeof -- `type` is a string
if (typeof options[key] === acceptedOptions[key].type) {
// Skip boolean options if false

Expand Down
6 changes: 3 additions & 3 deletions src/index.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable jest/no-conditional-expect */
/* eslint-disable security/detect-non-literal-fs-filename */
/* eslint-disable jest/no-conditional-expect -- Depends on the version of the binary */
/* eslint-disable security/detect-non-literal-fs-filename -- Test files are not user-provided */

"use strict";

Expand Down Expand Up @@ -88,7 +88,7 @@ describe("Node-Poppler module", () => {

expect.assertions(1);
try {
// eslint-disable-next-line no-unused-vars
// eslint-disable-next-line no-unused-vars -- This is intentional
const poppler = new Poppler();
} catch (err) {
expect(err.message).toBe(
Expand Down

0 comments on commit 07641df

Please sign in to comment.