Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeTS Challenge 2022: Task 1 #156

Merged
merged 15 commits into from
May 4, 2022

Conversation

psfoley
Copy link
Collaborator

@psfoley psfoley commented May 3, 2022

This PR:

  • Uses the new FeTSChallengeTaskRunner implementation
  • Adapts the Custom Aggregation Functions to use a writable dataframe (i.e. for easy storage of metrics / globals)
  • Updated references to FeTS 2022 Training/Validation Data
  • Convert jupyter notebook to a script (for easier submission reproduction)
  • Tensorboard support and integration

Steps required before merge:
[ x ] - Flag to skip Hausdorff 95 metrics
[ x ] - Additional testing of code on CPU / GPU
[ x ] - Final verification of FeTS Challenge plan parameters
[ x ] - New aggregation function interface examples
[ x ] - Bring documentation up to date

Improvements to expect after merge:
[ ] - Launch collaborator's in their own process for faster training

sarthakpati
sarthakpati previously approved these changes May 3, 2022
Copy link
Member

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Waiting for mlcommons/GaNDLF#422 to merge.

@sarthakpati
Copy link
Member

Converting to draft till ready for merge.

…able Hausdorff metrics. Removed option to selectively run validation metrics (will likely come back in future PR). Get experiment run number dynamically for inference (instead of needing to set it ahead of time)
@psfoley psfoley changed the title WIP: FeTS Challenge 2022: Task 1 FeTS Challenge 2022: Task 1 May 3, 2022
@psfoley psfoley marked this pull request as ready for review May 3, 2022 23:35
Copy link
Member

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarthakpati sarthakpati merged commit 3284cc4 into FeTS-AI:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants