Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLCubes for evaluation #171

Merged
merged 15 commits into from
Jun 17, 2022
Merged

Add MLCubes for evaluation #171

merged 15 commits into from
Jun 17, 2022

Conversation

mzenk
Copy link
Collaborator

@mzenk mzenk commented May 30, 2022

This PR gathers all MLCubes required for running the evaluation of task 2 in the official challenge repository (previously distributed among medperf repo and mlcube_examples repo). At the same time, it also updates these cubes so that they use the challenge I/O conventions.

This is still WIP.

  • Make the BraTS MedPerf example compatible with the FeTS conventions
  • Test individual MLCubes
  • Run MedPerf pipeline (compatibility test)
  • Add documentation how to run compatibility test for participants
  • (optional) Add logging to data preparation cube

aristizabal95
aristizabal95 previously approved these changes Jun 14, 2022
Copy link
Collaborator

@aristizabal95 aristizabal95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a few comments, which are mostly typos I noticed.

Task_2/mlcubes/model/README.md Outdated Show resolved Hide resolved
Task_2/mlcubes/model/README.md Outdated Show resolved Hide resolved
Task_2/mlcubes/model/README.md Outdated Show resolved Hide resolved
Task_2/mlcubes/model/README.md Outdated Show resolved Hide resolved
@mzenk mzenk marked this pull request as ready for review June 15, 2022 08:08
@mzenk
Copy link
Collaborator Author

mzenk commented Jun 16, 2022

@sarthakpati @ujjwalbaid0408 would be great if one of you could merge this today.

@ujjwalbaid0408 ujjwalbaid0408 merged commit 0e1fef8 into FeTS-AI:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants