Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license of model cube and data preparation cube #180

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

mzenk
Copy link
Collaborator

@mzenk mzenk commented Jun 20, 2022

Apache v2 now (same as overall Task 2 repo)

@mzenk mzenk requested a review from sarthakpati June 20, 2022 14:44
@sarthakpati sarthakpati requested review from ujjwalbaid0408 and removed request for sarthakpati June 20, 2022 20:59
@sarthakpati
Copy link
Member

hey @mzenk, I am on leave ATM. Asking @ujjwalbaid0408 to review instead.

@mzenk mzenk changed the title Update license of model cube Update license of model cube and data preparation cube Jun 24, 2022
@mzenk
Copy link
Collaborator Author

mzenk commented Jun 24, 2022

UPDATE: I added a commit for extending the data preparation cube. It supports having a validation split file (used during fed. eval.) and has an improved sanity check.

@mzenk
Copy link
Collaborator Author

mzenk commented Jun 28, 2022

@ujjwalbaid0408 Friendly reminder to review this before July 1

@mzenk mzenk requested a review from dzimmerer June 30, 2022 13:01
Copy link

@dzimmerer dzimmerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mzenk mzenk merged commit 304dcc1 into FeTS-AI:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants