Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of data preparation cube #186

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Update of data preparation cube #186

merged 4 commits into from
Aug 25, 2022

Conversation

mzenk
Copy link
Collaborator

@mzenk mzenk commented Jul 31, 2022

This PR adds a fix and some updates that are relevant for the federated evaluation.

  • Fixes handling of split files
  • Adds simple anonymization to subject directories
  • Extends configurability of data preparation cube
  • Adds a couple of tests

msheller
msheller approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@msheller msheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, Max! I'm a little concerned about the "x.glob(...)" not checking for specific files, but I know that's in the original logic, so we can go with it for now. In the future, we should revisit this with the UPenn team.

@msheller msheller merged commit bb4efea into FeTS-AI:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msheller msheller msheller approved these changes

@aristizabal95 aristizabal95 Awaiting requested review from aristizabal95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mzenk @msheller