-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignored devs-(bugs enclosed) #143
Comments
First of all, which branch/coder version are you referring to? I've problems to understand your comments, so let me comment on the points I understood:
Finally let me tell you, that I'm sorry that you lost your changes. I assume you improved the wallet's code and lost it. Unfortuntely I didn't see any pull request from you so I don't know what you coded. If you want to help coding, please fork the repository into your own workspace, do your changes on the a new branch, probably containing you name in the branch-ID and create a pull request to the feathercoin git repository. This way we can include the changes from different coders into the code and use Githubs code checks to avoid code coming from one developer being reversed/overwritten by changes from another coder. |
Hi Jazzmaster, Some of those changes could be rejected, or have been done as part of testing and updating for Feathercoin version 0.9.6. We have considered wither changing names from Bitcoin to FTC in every case is a good idea, it generates a lot of unnecessary work, when future Forks are converted. It has already been considered, unless there is some other reason. These issues need to be discussed in the Feathercoin development threads on the forum to gain some acceptance by other contributers. http://forum.feathercoin.com/category/71/technical-development I note your changes are still on your fork, so you could try and resubmit any that have been missed? I would be interested what the libzxing change, but we already have a million more important things that should be done, as part of the 0,9.6 release, so we don't need to be diverted unnecessarily i.e. unless it is important. |
I think we can sign this of. No response from Jazz Master. We can review his comments make an issue for each point, in the build tests. I've made a list of the relevant points.
|
Closing this. JazzMasters concerns were addressed with the 0.9.6 release. |
6f53edb Acquire cs_main before ATMP call in block_assemble bench (James O'Beirne) Pull request description: Calling `bench_bitcoin` currently fails due to calling ATMP without acquiring cs_main first in the recently added block_assemble bench (bitcoin/bitcoin#13219). ``` $ cat <(uname -a) <(gcc --version) Linux james 4.4.0-119-generic #143+jamesob SMP Mon Apr 16 21:47:24 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 $ ./src/bench/bench_bitcoin WARNING: This is a debug build - may result in slower benchmarks. # Benchmark, evals, iterations, total, min, max, median Assertion failed: lock cs_main not held in validation.cpp:566; locks held: [1] 19323 abort (core dumped) ./src/bench/bench_bitcoin ``` ``` (gdb) bt #0 0x00007fbdc9cf5428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x00007fbdc9cf702a in __GI_abort () at abort.c:89 #2 0x0000555a19580dc5 in AssertLockHeldInternal (pszName=pszName@entry=0x555a19834549 "cs_main", pszFile=pszFile@entry=0x555a1988a001 "validation.cpp", nLine=nLine@entry=566, cs=cs@entry=0x555a19ba55c0 <cs_main>) at sync.cpp:157 #3 0x0000555a194b395f in AcceptToMemoryPoolWorker (chainparams=..., pool=..., state=..., ptx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=1532964079, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=@0x7ffcbc1719d8: 0, coins_to_uncache=std::vector of length 0, capacity 0, test_accept=false) at validation.cpp:566 #4 0x0000555a194ba661 in AcceptToMemoryPoolWithTime (chainparams=..., pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, nAcceptTime=<optimized out>, plTxnReplaced=0x0, bypass_limits=false, nAbsurdFee=0, test_accept=false) at validation.cpp:998 #5 0x0000555a194ba7ce in AcceptToMemoryPool (pool=..., state=..., tx=std::shared_ptr (count 1, weak 0) 0x555a1bb819b0, pfMissingInputs=pfMissingInputs@entry=0x0, plTxnReplaced=plTxnReplaced@entry=0x0, bypass_limits=bypass_limits@entry=false, nAbsurdFee=0, test_accept=false) at validation.cpp:1014 #6 0x0000555a19363fbe in AssembleBlock (state=...) at bench/block_assemble.cpp:102 #7 0x0000555a193654d3 in std::_Function_handler<void (benchmark::State&), void (*)(benchmark::State&)>::_M_invoke(std::_Any_data const&, benchmark::State&) (__functor=..., __args#0=...) at /usr/include/c++/5/functional:1871 #8 0x0000555a193501d7 in std::function<void (benchmark::State&)>::operator()(benchmark::State&) const (this=this@entry=0x555a1ba2cda0, __args#0=...) at /usr/include/c++/5/functional:2267 #9 0x0000555a1934ec4c in benchmark::BenchRunner::RunAll (printer=..., num_evals=5, scaling=<optimized out>, filter=..., is_list_only=false) at bench/bench.cpp:121 #10 0x0000555a1934ade9 in main (argc=<optimized out>, argv=<optimized out>) at bench/bench_bitcoin.cpp:92 ``` Tree-SHA512: fdd7b28ff123ccea7a4f334d53f735d0c0f94aa9cc52520c2dd34dca45d78c691af64efcd32366fc472fedffbd79591d2be2bb3bfc4a5186e8712b6b452d64e3
Im a little teed off at the ignored changes proposed.
1- I was attempting --I lost my changes but they can be automated-- to change from BITCoin to Feather. This includes naming conventions, ICONS, etc. We are not BIT, not Satoshi and our code should reflect this.
(I can update this for .9, just dont have time rite this second. I asked for upload permissions and got sent in loops.)
I am aware some functions, like voting, however, merge from the master tree. It would be better just to implement the function, rather rewrite OUR code repeatedly as a result of "master Satoshi" code changes.
2- I have a few bug to go with #1 that didnt get in here for some reason.
wallets:
public key is too big and runs off the page
no QR codes, as if built without lib zebra crossing or libqrencode when printed.
Paper wallet is wide enough but too small. Without QR codes, impossible to read
exchanges:
(dont rely so much on others, failures)
we have half busted code here because people are dropping us and also not putting us back in places like shapeshift.io. take out/disable the option or demand we get put back in the exchange.
All I asked on the theme, and background (QT UI) was that we be consistent and PROFESSIONAL looking. As I said, I was working on this. Pick an ICON SET for everyone to USE and STICK WITH IT. The better we SELL, the more clients and traffic we generate.
Someone needs also to CLEAN UP the code and layout, in mind we are devving for DROID (still working this one out), and MULTIPLE OS and arch. It would behoove someone to (AT FTC website) post OUR packages ON OUR SITE. (this IS possible, even with WP). AGAIN. Ignored.
64 bit Linux seems missing, beggin for 32 bit depends that on 64 bit CANNOT exist. This forces 64 bitters to RECOMPILE, which until recently with .9 WAS NOT POSSIBLE.
ALSO:
messaging of sort that an update is out within the app would be nice. BTC HAD this feature.
The text was updated successfully, but these errors were encountered: