This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
store remoteAvailableShards to file #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisturner
force-pushed
the
save-available-shards
branch
from
e4e3eb4
to
cdfcd6d
Compare
jaffee
previously approved these changes
Sep 24, 2018
field.go
Outdated
|
|
||
| // Write available shards to buffer. | ||
| var buf bytes.Buffer | ||
| if n, err := f.remoteAvailableShards.WriteTo(&buf); err != nil { |
There was a problem hiding this comment.
why write to a buffer rather than directly to the file?
There was a problem hiding this comment.
good catch. i removed it in ee503b6
jaffee
reviewed
Sep 24, 2018
| // saveAvailableShards writes remoteAvailableShards data for the field. | ||
| func (f *Field) saveAvailableShards() error { | ||
| // Open or create file. | ||
| file, err := os.OpenFile(filepath.Join(f.path, ".available.shards"), os.O_WRONLY|os.O_CREATE, 0666) |
There was a problem hiding this comment.
does this truncate by default or should we pass that flag explicitly
There was a problem hiding this comment.
it truncates by default. you have to include os.O_APPEND to append.
jaffee
approved these changes
Sep 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the previous attempt (#1659) at making
remoteAvailableShardsimmediately available after startup.Pull request checklist
Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.