This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
uncomment old LIMIT tests, make them pass #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forward-ported a handful of tests from the previous parser which relied on LIMIT clauses, but then we didn't support that. Now that we do, we uncomment most of these tests, and actually give them the correct data structures to compare with. We leave two tests commented out. One was using `limit 10, 5` to express a limit plus offset, and the other is using `not fld = 1` as a WHERE clause, but we don't support unary-not to negate other expressions. In the process, we discover that converting a SELECT with a LIMIT clause back to a string has a missing space, and fix that.
|
Kudos, SonarCloud Quality Gate passed!
|
lorycloutier
approved these changes
Apr 6, 2023
liuxisong
pushed a commit
to liuxisong/pilosa
that referenced
this pull request
Jul 7, 2023
(cherry picked from commit 2796344)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forward-ported a handful of tests from the previous parser which relied on LIMIT clauses, but then we didn't support that. Now that we do, we uncomment most of these tests, and actually give them the correct data structures to compare with.
We leave two tests commented out. One was using
limit 10, 5to express a limit plus offset, and the other is usingnot fld = 1as a WHERE clause, but we don't support unary-not to negate other expressions.In the process, we discover that converting a SELECT with a LIMIT clause back to a string has a missing space, and fix that.