When changing the feature model, markers are not updated.

[skrieter]

Prerequisitives

• Eclipse Version: Neon.2
• FeatureIDE-Version: 3.4
• Operating system: Windows
• Java runtime used to run eclipse: 1.8
• FeatureIDE Composer: all
• Git branch/Commit-ID: develop
• Java compiler used to build the FeatureIDE plugin:

Issue description

Changing a feature model (e.g., removing a void constraint) does not clear the respective error markers.
Eclipse should perform a clean and (maybe) a build after saving a modified feature model.

[tthuem]

@skrieter Do we need this for the tutorial?

[Kogoro]

@tthuem We checked the issue and these were the only markers:

Even after a build, this does not change.

[tthuem]

The change in the code does not look right. Also, why do those markers not appear anymore?

@PaulWestphal Paul, could you please check whether it works for the tutorial now? (i.e., there are only markers that we need for the tutorial)

[PaulWestphal]

Hands On II problems:

Occasionally when loading Elevator v1.0, I don't get the "The feature model is void" marker. This doesn't happen very often.

The "Configuration 'x' is invalid" markers don't show up at all when the feature model is void unless I save the feature model without fixing it.

After completing step 4. in the hands on, Info markers sometimes appear up to three times.

e: I just got the info markers seven times by just following the steps of the Hands On, but I'm still unsure how to reproduce this.

[tthuem]

Note sure what is going on here, but we are not getting closer to the version for the tutorial.

@Kogoro @subaro Would be good if you could test the complete tutorial, too.

@skrieter We might need you help to get a stable version in time.

[Kogoro]

Regarding the not showing void marker: The sat solver delivers true as a result of the isValid() call. Then the marker is not created.
We will take a look at the configuration markers.

[Kogoro]

I made a quick fix for the markers. On build, there will be called a method for checking the most common problems.
@PaulWestphal @subaro Please test on the quickfix branch.

[PaulWestphal]

When loading Elevator v1.0 on the quickfix branch "building workspace" never stops. That makes it impossible to run the elevator.

[Kogoro]

5366e89 should solve the rebuild issue. It appeared only sometimes when the feature model was overridden.