Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving dimacs to xml ignores features not occurring in constraints #869

Closed
meinicke opened this issue Mar 7, 2019 · 0 comments
Closed

Comments

@meinicke
Copy link
Contributor

meinicke commented Mar 7, 2019

Prerequisitives

  • Eclipse Version: 2018-12
  • FeatureIDE-Version: 3.5
  • Operating system: WIN 10
  • Java runtime used to run eclipse: 1.8
  • FeatureIDE Composer: Feature Modeling
  • Git branch/Commit-ID: N/A
  • Java compiler used to build the FeatureIDE plugin: N/A

Issue description

When saving (probably when loading directly) dimacs files to xml, FEatureIDE ignores features that do no appear in constraints.
The dimacs parser should use all the features defined in the first rows befor the "p cnf x y" entry, they are meant to be optional.

As shown below, the dimacs file declares 6 features, but the xml has only 4, the 4 that appear in constraints.

featureidebug2

The dimacs file I used:
c 1 base
c 2 weight
c 3 empty
c 4 executivefloor
c 5 twothirdsfull
c 6 overloaded
p cnf 6 3
-6 2 0
-5 2 0
1 0

@meinicke meinicke changed the title Saving dimacs to xml invalid Saving dimacs to xml deletes features Mar 7, 2019
@meinicke meinicke changed the title Saving dimacs to xml deletes features Saving dimacs to xml ignores features declared in comments Mar 8, 2019
@tthuem tthuem changed the title Saving dimacs to xml ignores features declared in comments Saving dimacs to xml ignores features not occurring in constraints Mar 11, 2019
@tthuem tthuem added this to the 3.5.5 (April) milestone Mar 11, 2019
@tthuem tthuem modified the milestones: 3.5.5 (April), 3.6.0 (June) Apr 23, 2019
skrieter pushed a commit that referenced this issue May 28, 2019
Fixed null pointer for constraint dialog.
Fixed potential null pointer for getting analysis results for specific
features or constraints.
Fixed problem with FeatureIDE context menu.
Fixed #868.
Fixed #869.
@skrieter skrieter closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants