Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sklearn version requirements #541

Merged
merged 1 commit into from May 10, 2019
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented May 10, 2019

sklearn 0.21 doesn't support python 27 so we must adjust our version requirement

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #541 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files         114      114           
  Lines        9258     9258           
=======================================
  Hits         8912     8912           
  Misses        346      346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d399898...fef0947. Read the comment docs.

@rwedge rwedge requested a review from kmax12 May 10, 2019 15:29
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit 8f8a94f into master May 10, 2019
@rwedge rwedge deleted the update-sckikit-learn-req branch May 10, 2019 15:59
@rwedge rwedge mentioned this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants