Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Tar File #720

Merged
merged 8 commits into from Aug 29, 2019
Merged

Close Tar File #720

merged 8 commits into from Aug 29, 2019

Conversation

jeff-hernandez
Copy link
Contributor

@jeff-hernandez jeff-hernandez commented Aug 29, 2019

This PR closes a tar file left open in read_entityset

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         118      118           
  Lines       10201    10201           
=======================================
  Hits         9960     9960           
  Misses        241      241
Impacted Files Coverage Δ
featuretools/entityset/deserialize.py 99.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46bd32d...ccc5fd3. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeff-hernandez jeff-hernandez merged commit 3195659 into master Aug 29, 2019
@jeff-hernandez jeff-hernandez deleted the hotfix branch August 29, 2019 18:27
@rwedge rwedge mentioned this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants