Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Tar File #720

Merged
merged 8 commits into from Aug 29, 2019

Conversation

@jeff-hernandez
Copy link
Collaborator

commented Aug 29, 2019

This PR closes a tar file left open in read_entityset

@codecov

This comment has been minimized.

Copy link

commented Aug 29, 2019

Codecov Report

Merging #720 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         118      118           
  Lines       10201    10201           
=======================================
  Hits         9960     9960           
  Misses        241      241
Impacted Files Coverage Δ
featuretools/entityset/deserialize.py 99.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46bd32d...ccc5fd3. Read the comment docs.

@kmax12 kmax12 requested review from jeremyliweishih and rwedge Aug 29, 2019
@rwedge
rwedge approved these changes Aug 29, 2019
Copy link
Collaborator

left a comment

Looks good

Copy link
Contributor

left a comment

Looks good!

@jeff-hernandez jeff-hernandez merged commit 3195659 into master Aug 29, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.63%)
Details
codecov/project 97.63% (+0%) compared to 46bd32d
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@jeff-hernandez jeff-hernandez deleted the hotfix branch Aug 29, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.