Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting packages #747

Merged
merged 4 commits into from Sep 17, 2019

Conversation

@rwedge
Copy link
Collaborator

commented Sep 17, 2019

Our linting-related dependencies were out of date, and this was causing some errors if users were trying run make lint using the latest versions of these packages (example).

This PR updates our dependencies to the latest versions and fixes the error encountered when using the new versions.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@codecov

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #747 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         118      118           
  Lines       10356    10356           
=======================================
  Hits        10113    10113           
  Misses        243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f81753...7dba9dd. Read the comment docs.

@kmax12
kmax12 approved these changes Sep 17, 2019
@rwedge rwedge merged commit 67322e5 into master Sep 17, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 9f81753...7dba9dd
Details
codecov/project 97.65% remains the same compared to 9f81753
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the update-linting-packages branch Sep 17, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.