Update dtype on DataColumn object instead of DataTable #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170
Moves the
_update_dtype
method to the DataColumn object, so that instantiating a column directly will modify the series dtype as needed depending on the LogicalType.Updated
DataTable._update_columns
method to make sure dataframe stays in sync with column series data since callingastype
on a series returns a new series object.Updated various test as a result of these changes and added new DataColumn tests to confirm physical types are changed as expected.