Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Mutual Info #390

Merged
merged 8 commits into from Nov 16, 2020
Merged

Rename Mutual Info #390

merged 8 commits into from Nov 16, 2020

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented Nov 16, 2020

@ctduffy ctduffy requested a review from gsheni November 16, 2020 16:13
@ctduffy
Copy link
Contributor Author

ctduffy commented Nov 16, 2020

@gsheni Really confused why my unit tests are failing. It seems unrelated to my PR, but also the main branch doesn't seem to have these failures...

@thehomebrewnerd
Copy link
Contributor

@gsheni Really confused why my unit tests are failing. It seems unrelated to my PR, but also the main branch doesn't seem to have these failures...

@ctduffy The latest release of Koalas broke a lot of things. I'm working on fixing now, but until my fix is merged in, the tests will continue to fail - unless you restrict the Koalas version to be <=1.3.0.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #390 (5a5af94) into main (5d91521) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         3781      3781           
=========================================
  Hits          3781      3781           
Impacted Files Coverage Δ
woodwork/datatable.py 100.00% <100.00%> (ø)
woodwork/tests/datatable/test_datatable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d91521...5a5af94. Read the comment docs.

koalas-requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just 1 minor thing.

docs/source/release_notes.rst Show resolved Hide resolved
@gsheni gsheni merged commit 7b5bc2d into main Nov 16, 2020
@gsheni gsheni deleted the rename-mi branch November 16, 2020 19:07
@gsheni gsheni mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename get_mutual_information to mutual_information
3 participants