Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primitive Function redundant casting #562

Closed
ctduffy opened this issue May 23, 2019 · 4 comments · Fixed by #1020
Closed

Primitive Function redundant casting #562

ctduffy opened this issue May 23, 2019 · 4 comments · Fixed by #1020
Assignees
@thehomebrewnerd
Labels
good first issue Good for newcomers

Comments

@ctduffy
Copy link
Contributor

ctduffy commented May 23, 2019

The primitive functions in transform_primitives take in a pandas series as an input, so inside these primitives it is no longer necessary to cast the input to a Series.
@ctduffy ctduffy added the good first issue Good for newcomers label May 23, 2019
@rsvarma95
Copy link

Can I work on this issue ?

@kmax12
Copy link
Contributor

kmax12 commented May 27, 2019 •
edited

@Raul9595 sure! just put up a PR once you are ready for us to review

@kmax12
Copy link
Contributor

kmax12 commented Jul 19, 2019

@Raul9595 are you still planning to work on this issue?

@rwedge
Copy link
Contributor

rwedge commented May 20, 2020

Many of these castings will be removed by #783

@thehomebrewnerd thehomebrewnerd mentioned this issue Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehomebrewnerd thehomebrewnerd

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary pd.Series calls in primitives alteryx/featuretools
5 participants
@kmax12 @thehomebrewnerd @rwedge @ctduffy @rsvarma95