Primitive refactor updates #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmax12
approved these changes
Jan 8, 2019
| @@ -225,8 +225,7 @@ def __sub__(self, other): | |||
| return self._handle_binary_comparision(other, primitives.SubtractNumeric, primitives.SubtractNumericScalar) | |||
|
|
|||
| def __rsub__(self, other): | |||
| # TODO | |||
| pass | |||
| return self._handle_binary_comparision(other, primitives.SubtractNumeric, primitives.ScalarSubtractNumeric) | |||
There was a problem hiding this comment.
let's rename to SubtractNumericFeature and Scalar SubtractNumericFeature
|
good to merge after the one comment |
…ic_feature and scalar_subtract_numeric_feature
rwedge
pushed a commit
that referenced
this pull request
Jan 18, 2019
* initial support * cfm tests passing * linting * progress * progress * add lint-fix and autopep * more passing * progress * progress * progress * don't require initialization * separate override tests * lint * cleanup * more tests passing * one more test passing * all but one test passing * all test pass * linting * add to lint-fix * all tests pass! * cleanup * fix tests * fix test * fix linting * docs building * actually fix docs * updates * Primitive refactor updates (#365) * remove incorrect commutative attributes * handle rsub override and test reverse overrides * rename weekend primitive is_weekend * updated weekend to is_weekend in docs * test values for scalar_subtract_numeric * rename subtract_numeric and scalar_subtract_numeric to subtract_numeric_feature and scalar_subtract_numeric_feature * revert subtract_numeric_feature to subtract_numeric * update rsub * fix test * cleanup * remove unecessary primitive initializations * addressed review comments
rwedge
added a commit
that referenced
this pull request
Jan 19, 2019
* initial support * cfm tests passing * linting * progress * progress * add lint-fix and autopep * more passing * progress * progress * progress * don't require initialization * separate override tests * lint * cleanup * more tests passing * one more test passing * all but one test passing * all test pass * linting * add to lint-fix * all tests pass! * cleanup * fix tests * fix test * fix linting * docs building * actually fix docs * updates * Primitive refactor updates (#365) * remove incorrect commutative attributes * handle rsub override and test reverse overrides * rename weekend primitive is_weekend * updated weekend to is_weekend in docs * test values for scalar_subtract_numeric * rename subtract_numeric and scalar_subtract_numeric to subtract_numeric_feature and scalar_subtract_numeric_feature * revert subtract_numeric_feature to subtract_numeric * update rsub * fix test * replace expanding with number_output_features * remove old line from encode features * have dfs intialized un-initialized primitives * fix feature name assertion * remove get_feature_names on primitive * cleanup * test direct features of multi output features * linting * remove unecessary primitive initializations * rename NMostCommon primitive function * remove unecessary default value from NMostCommon * allow NMostCommon to stack * don't set primitive for DirectFeature * make number_output_features a property of FeatureBase * change parameter name in check_stacking * rename ready_primitive to handle_primitive and add check that input is a primitive * update variable name in where primitive check * switch to using feature.number_output_features in logic * add warning in encode_features for multi output features * make helper function for adding feature values to existing data * clean up direct feature tests on multi-output features * addressed review comments * remove logic to do direct features of grandparents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.