Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variable in normalize_entity. #589

Merged
merged 2 commits into from Jun 10, 2019
Merged

Removed unused variable in normalize_entity. #589

merged 2 commits into from Jun 10, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Jun 10, 2019

  • Remove an unused variable in normalize_entity

@codecov
Copy link

codecov bot commented Jun 10, 2019 •
edited

Codecov Report

Merging #589 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   96.43%   96.43%   -0.01%     
==========================================
  Files         117      117              
  Lines        9522     9521       -1     
==========================================
- Hits         9183     9182       -1     
  Misses        339      339
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 94.96% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d91985...7965245. Read the comment docs.

@gsheni gsheni changed the title Update entityset.py Removed unused variable in normalize_entity. Jun 10, 2019
rwedge
rwedge approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit cde74cf into master Jun 10, 2019
@gsheni gsheni deleted the fix_normalize_var branch June 10, 2019 16:33
@rwedge rwedge mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gsheni @rwedge