Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Commit

Permalink
CVE-2015-0256: Mark auth_ses cookie as secure
Browse files Browse the repository at this point in the history
This cookie is used to skip authentication within 5 minutes.
If this is stolen, someone can steal you identity in FedOAuth.
  • Loading branch information
puiterwijk committed Feb 4, 2015
1 parent f636524 commit 135c1c1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion fedoauth/auth/base.py
Expand Up @@ -22,6 +22,7 @@
from flask import request, render_template
import logging

from fedoauth import APP
from fedoauth.model import Remembered


Expand Down Expand Up @@ -189,7 +190,8 @@ def save_success(self, user, remember=True):
self.full_name,
authsesid)
request.set_cookie('%s_auth_ses' % self.full_name,
signed_authsesid)
signed_authsesid,
secure=APP.config['GLOBAL']['cookies_secure'])
logger.debug('Cookie set')

logger.debug('Login complete')
Expand Down

0 comments on commit 135c1c1

Please sign in to comment.