Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fate v1.1 k8s deploy #30

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Conversation

owlet42
Copy link
Collaborator

@owlet42 owlet42 commented Nov 12, 2019

Signed-off-by: ChenLong Ma owlet42@126.com

Changes:

  1. update configMap

  2. update readme

  3. update helm chart version

Signed-off-by: ChenLong Ma <owlet42@126.com>
Copy link
Contributor

@LaynePeng LaynePeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the definition of FATE project, the egg node should be worker node, and the "worker" nodes here are a combination of meta-data and other module nodes: https://github.com/FederatedAI/FATE/tree/9d1d9010cbad9943a7657eed248069f0ed6160ee/cluster-deploy we should scale out egg nodes for HP purpose. I think the Chinese and English README files should be changes.

@jiahaoc1993
Copy link
Contributor

let's stop passing the "useThirdParty" argument to the create-helm-deploy.sh. We could add the "RegistryURI" to the .env to specify which private registry should be used(use docker hub if blank value was assigend).

Signed-off-by: ChenLong Ma <owlet42@126.com>
Signed-off-by: ChenLong Ma <owlet42@126.com>
@LaynePeng LaynePeng merged commit 6535166 into FederatedAI:master Nov 13, 2019
@owlet42 owlet42 deleted the k8s-deploy-v1.1 branch November 14, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants