-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent usage of event attributes #6
Comments
Hi again 😃! The consistency comes from the relation between the relative attribute and the attribute that is most important/useful/defining to the event, as the angle to a Twist, the distance between fingers for a Pinch, or the center for Drag. I think this must change if we reach the point that there are two or more of these attributes but for now I think is the best way of handling this. Of course as I might be wrong, if anyone else reading this agrees with ichbindu or with me please let me know so I can reconsider it. P.S What do you mean when you say that the angle is undocumented, there is not an |
That makes sense to me. Let's see what others think. In my specific use case I wanted to use
Sorry I was a bit unclear with what I wrote. I meant that |
Ok. Anyways, if you implement that workaround to get the pinch relative movement and find it useful let me know.
Just updated the documentation, thanks! |
Again, great work! I've got a minor suggestion when it comes to consistency of
event
attributes:Under drag events like
InputEventSingleScreenDrag
,event.relative
relates toevent.position
. UnderInputEventScreenPinch
andInputEventScreenTwist
, however,event.relative
relates toevent.distance
and angle (the former undocumented btw) whileevent.position
is still present.I think it'd be preferable to keep
event.relative
related toevent.position
and introduce different attributes for distance and angle.The text was updated successfully, but these errors were encountered: