Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku fix #15

Closed
wants to merge 2 commits into from
Closed

Heroku fix #15

wants to merge 2 commits into from

Conversation

23min
Copy link
Contributor

@23min 23min commented Oct 7, 2012

The dependencies in setup.py were not being processed if beaker package was not already installed.
This was because setup.py depended on cork. Hence, when running pip, a compile of cork was initiated which failed because beaker package was not present.

I've removed the dependency and now bottle-cork can pip install, which means it finally works on Heroku. (The reason it failed on Heroku was because requirements.txt processes dependencies from github before pypy packages. This is apparently a limitation of pip.) I was using my bottle-cork@current fork for testing)
So, 'forcing' installation of beaker and pycrypt before bottle-cork in requirements.txt by putting them in the right order did not work.

…ottle-cork fails if beaker is not installed yet. Couldn't use cork on Heroku without this fix
@FedericoCeratto
Copy link
Owner

Thanks for the patch. I've moved version to the init.py file to keep the version number in one location only.
The 'pycrypto' module, being a part of Beaker, should not be a direct dependency I suppose.

BTW, do you have an email address that I can put in a contributor list file? Thanks

@23min
Copy link
Contributor Author

23min commented Oct 7, 2012

I suppose you're right, but when I had initially installed bottle, beaker and bottle-cork previously, I needed to install pycrypto manually.
I have not tested now with the change in bottle-cork, so I would recommend testing this.

You can add me with peter@23min.com

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants