Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighter (disabled?) text drawn for unfocused views. #126

Closed
CDrummond opened this issue Dec 4, 2019 · 15 comments · Fixed by #183
Closed

Lighter (disabled?) text drawn for unfocused views. #126

CDrummond opened this issue Dec 4, 2019 · 15 comments · Fixed by #183

Comments

@CDrummond
Copy link
Contributor

As can be seen in the following kid3-qt screenshot, a ligher grey text is used to draw views that currently don't have focus. This looks odd, and (espcially in kd3-qt's case) makes the app harder to use.

kid3-text

The vie won th eleft also does not have focus, so not sure exactly what is going on. But, if the table-view within the right had side vide gets focus, then its text turns black.

@grulja
Copy link
Collaborator

grulja commented Apr 20, 2020

I pushed e671e8e, which fixes it for QTreeView, but I was unable to find a solution for QTableView and QListView. They seem to be rendered differently and I already spent hours trying to find a solution. I will keep this opened, but I have no idea at this moment how to fix it.

@uklotzde
Copy link

Mixxx also seems to be affected by the latest changes in 1.1.2 (crashes) and 1.1.3. Both QTreeView and QTableView are affected depending on focus:

adwaita-qt5-1.1.1:
palette_before

adwaita-qt5-1.1.3:
palette_after

Version 1.1.1 worked for us, version 1.1.2/1.1.3 is unusable right now.

@uklotzde
Copy link

Colors in QTreeView and QTableViw are now changing from inactive to active in unforeseeable ways depending on the focus. Maybe caused by the recent commits during Apr 2020 targeting unfocused views?

@grulja
Copy link
Collaborator

grulja commented May 15, 2020

The reason why I did it this way is that Qt doesn't distinguish between inactive widget and inactive window. For example you could have a tree view in your app, the app had focus on a different widget and the tree view was grey, looking like the whole application not having focus. To fix that, I just check whether the main window has focus and set inactive palette to have colors from the active one.

Why Mixxx use grey color for text when it's active?

@uklotzde
Copy link

The screenshots were taken with Mixxx in fullscreen mode. I need to check whether switching the window modes affects the behavior.

Maybe @ronso0 could provide some insights how the focus handling between different views in Mixxx works.

@grulja
Copy link
Collaborator

grulja commented May 15, 2020

Ok, I think I know why this is happening. You probably set some custom color to the view and we change it back to Adwaita default palette when the window looses focus. I will fix it during the weekend.

@grulja
Copy link
Collaborator

grulja commented May 18, 2020

Can you try e5dfd0b for the Mixxx issue?

@uklotzde
Copy link

Great! Works as expected in all modes (fullscreen/window). The color scheme is now preserved after activating the menu bar.

@Be-ing @ronso0 Tested with both Deere and Tango on master.

@Be-ing
Copy link

Be-ing commented May 18, 2020

That works, but I can only get the theme to apply to Qt applications when I run them from KDE... now my fonts are all tiny after changing something in KDE system settings... even erasing ~/.config didn't fix it 😢

@grulja
Copy link
Collaborator

grulja commented May 18, 2020

That works, but I can only get the theme to apply to Qt applications when I run them from KDE... now my fonts are all tiny after changing something in KDE system settings... even erasing ~/.config didn't fix it

You can force the theme with QT_STYLE_OVERRIDE=adwaita.

No idea why your fonts are tiny, this is unfortunately not related to Adwaita at all.

@Awem
Copy link

Awem commented Jul 2, 2020

On adwaita-qt 1.1.4 KeePassXC still looks like this:
image
Is there some way to fix this?

This is how it looks on 1.1.1:
image

@grulja
Copy link
Collaborator

grulja commented Jul 6, 2020

On adwaita-qt 1.1.4 KeePassXC still looks like this:
image
Is there some way to fix this?

This is how it looks on 1.1.1:
image

Can you be more specific about the area where you see this? Maybe a whole screenshot? Running it myself I don't have any problem with it.

@Awem
Copy link

Awem commented Jul 6, 2020

Ah, okay. Maybe this helps:

  1. create a new entry with any title
  2. choose "clone entry" on the context menu of that new entry
  3. make sure the second checkbox concerning the references is checked

@Awem
Copy link

Awem commented Jul 14, 2020

@grulja the light text is no longer an issue with KeePassXC 2.6.0

@polter-rnd
Copy link
Contributor

Fixed in #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants