Workaround broken inactive window coloring applies incorrectly to list/tree/dock widgets in the active window #46847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to list/tree/dock widgets in the active window This is a theming issue which is apparent on certain default Linux themes, e.g. the when running QGIS under gnome. It results in incorrectly deciding that a widget belongs to an inactive window, causing unfocused list/tree or dock widgets to incorrectly show in the inactive color palette. On gnome at least this "inactive" palette defaults to an appearance very similar to the disabled widget color palette. As a result all unfocused list/tree/dock widgets look to be disabled until they are focused. This gross hack just force removes the inactive color palette under linux environments to block this theme behaviour
nirvn
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a theming issue which is apparent on certain default
Linux themes, e.g. the when running QGIS under gnome. It results
in incorrectly deciding that a widget belongs to an inactive
window, causing unfocused list/tree or dock widgets to incorrectly
show in the inactive color palette. On gnome at least this
"inactive" palette defaults to an appearance very similar to
the disabled widget color palette. As a result all unfocused
list/tree/dock widgets look to be disabled until they are focused.
This gross hack just force removes the inactive color palette
under linux environments to block this theme behaviour
Refs FedoraQt/adwaita-qt#126
Without fix: Notice the "disabled" looking text in the browser and the symbols library list in the dock
With fix: