fix query build bug

FeiniuBus · Nov 23, 2017 · 6920493 · 6920493
1 parent c46556b
commit 6920493
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/hmac_v1_sign.go b/hmac_v1_sign.go
@@ -244,6 +244,7 @@ func (ctx *signingCtx) buildCanonicalString() {
 		uri = ctx.URL.EscapedPath()
 	}
 
+	ctx.URL.RawQuery = strings.Replace(ctx.Query.Encode(), "+", "%20", -1)
 	ctx.canonicalString = strings.Join([]string{
 		ctx.Method,
 		uri,

diff --git a/hmac_v1_test.go b/hmac_v1_test.go
@@ -98,8 +98,8 @@ func TestValidator(t *testing.T) {
 
 func TestSignGetRequest(t *testing.T) {
 	values := url.Values{}
-	values.Set("id", "uuid")
-	values.Set("type", "Topic")
+	values.Set("type", "uuid")
+	values.Set("id", "Topic")
 
 	req := buildGetRequest(values)
 	signer := buildSigner()

diff --git a/hmac_v1_verify.go b/hmac_v1_verify.go
@@ -161,6 +161,7 @@ func (ctx *verifyCtx) buildCanonicalString() {
 		uri = ctx.URL.EscapedPath()
 	}
 
+	ctx.URL.RawQuery = ctx.Query.Encode()
 	ctx.canonicalString = strings.Join([]string{
 		ctx.Method,
 		uri,