[expo-av] Added ability to disable microphone permission (expo#13446)

* added ability to disable microphone permission * Update CHANGELOG.md
FelipeACP · Sep 18, 2021 · 7003845 · 7003845
1 parent f3f1d26
commit 7003845
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 18 deletions.
diff --git a/packages/expo-av/CHANGELOG.md b/packages/expo-av/CHANGELOG.md
@@ -8,6 +8,7 @@
 
 ### 🎉 New features
 
+- [plugin] Added ability to disable microphone permission via `microphonePermission: false`. ([#13446](https://github.com/expo/expo/pull/13446) by [@EvanBacon](https://github.com/EvanBacon))
 - Add web support for recording. ([#8721](https://github.com/expo/expo/pull/8721) by [@WazzaJB](https://github.com/WazzaJB) and [@mnightingale](https://github.com/mnightingale))
 - Add permissions support for web. ([#8721](https://github.com/expo/expo/pull/8721) by [@mnightingale](https://github.com/mnightingale))
 - Add Audio `usePermissions` hook from modules factory. ([#13851](https://github.com/expo/expo/pull/13851) by [@bycedric](https://github.com/bycedric))

diff --git a/packages/expo-av/plugin/build/withAV.d.ts b/packages/expo-av/plugin/build/withAV.d.ts
diff --git a/packages/expo-av/plugin/build/withAV.js b/packages/expo-av/plugin/build/withAV.js
diff --git a/packages/expo-av/plugin/src/withAV.ts b/packages/expo-av/plugin/src/withAV.ts
@@ -9,20 +9,25 @@ const pkg = require('expo-av/package.json');
 
 const MICROPHONE_USAGE = 'Allow $(PRODUCT_NAME) to access your microphone';
 
-const withAV: ConfigPlugin<{ microphonePermission?: string } | void> = (
+const withAV: ConfigPlugin<{ microphonePermission?: string | false } | void> = (
   config,
   { microphonePermission } = {}
 ) => {
-  config = withInfoPlist(config, config => {
-    config.modResults.NSMicrophoneUsageDescription =
-      microphonePermission || config.modResults.NSMicrophoneUsageDescription || MICROPHONE_USAGE;
-    return config;
-  });
+  if (microphonePermission !== false) {
+    config = withInfoPlist(config, config => {
+      config.modResults.NSMicrophoneUsageDescription =
+        microphonePermission || config.modResults.NSMicrophoneUsageDescription || MICROPHONE_USAGE;
+      return config;
+    });
+  }
 
-  return AndroidConfig.Permissions.withPermissions(config, [
-    'android.permission.RECORD_AUDIO',
-    'android.permission.MODIFY_AUDIO_SETTINGS',
-  ]);
+  return AndroidConfig.Permissions.withPermissions(
+    config,
+    [
+      microphonePermission !== false && 'android.permission.RECORD_AUDIO',
+      'android.permission.MODIFY_AUDIO_SETTINGS',
+    ].filter(Boolean) as string[]
+  );
 };
 
 export default createRunOncePlugin(withAV, pkg.name, pkg.version);