Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser.proxy.onRequest if possible #1456

Closed
FelisCatus opened this issue May 1, 2018 · 6 comments
Closed

Use browser.proxy.onRequest if possible #1456

FelisCatus opened this issue May 1, 2018 · 6 comments
Assignees

Comments

@FelisCatus
Copy link
Owner

See: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/proxy/onRequest

@Riajyuu
Copy link

Riajyuu commented May 23, 2018

@FelisCatus It this is ever implemented, Firefox branch of this extension will become completely different from Chrome and no way back.

@FelisCatus
Copy link
Owner Author

@Rictusempra The current implementation is already different from Chrome and we're already experiencing different behaviors. However, I do believe that moving to the onRequest API will solve more issues than it creates and that should be the way forward.

@FelisCatus
Copy link
Owner Author

v2.5.16 released with the new API (Firefox ONLY).

@aguegu
Copy link

aguegu commented Oct 26, 2021

So pac mode on v2.5.20, the latest version downloaded from firefox site, works for Firefox?

It looks it doesn't in my environment. But my pac config works fine if configured in the configure / proxy settings, but not so convenient compared to SwitchyOmega.

By the way, thank you for your awesome work, so we could breath some free air.

@shixudong2020
Copy link

shixudong2020 commented May 19, 2022

after firefox upgrde to 100.0.1,direct connection and system proxy behavior rollback to #1212 and #2213

@waingt
Copy link

waingt commented Jun 20, 2022

after firefox upgrde to 100.0.1,direct connection and system proxy behavior rollback to #1212 and #2213

@shixudong2020
See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/ProxyInfo
"direct": don't proxy the request. If this value is given, all other properties of this object are ignored. However, this setting doesn't override any proxy set by the user

https://support.mozilla.org/en-US/kb/connection-settings-firefox
Choose No proxy in Connection Settings will solve this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants