-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better detection of focused window with certain yabai features #66
Labels
Comments
FelixKratz
added
help wanted
Extra attention is needed
incompatibility
Some features do not work as expected when specific other tools are running
needs investigation
Further investigations need to be performed
labels
Feb 12, 2024
FelixKratz
changed the title
Better detection of focused window
Better detection of focused window with yabai SIP disabled features
Feb 12, 2024
FelixKratz
changed the title
Better detection of focused window with yabai SIP disabled features
Better detection of focused window with yabai features
Feb 12, 2024
FelixKratz
changed the title
Better detection of focused window with yabai features
Better detection of focused window with certain yabai features
Feb 12, 2024
FelixKratz
added
available on master
and removed
help wanted
Extra attention is needed
incompatibility
Some features do not work as expected when specific other tools are running
needs investigation
Further investigations need to be performed
labels
Feb 12, 2024
On current master, launching borders from |
This solved the issue I reported on #15! This is amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current heuristic applied to determine the focused user window is good enough in most cases, however, when JB is used in combination with some more advanced yabai features (e.g.
focus_follows_mouse autofocus
, or presenting multiple windows of the same app on different system sub-layers) this heuristic breaks apart.The motivation to use the current heuristic is that it does not require using the slow accessibility API but only fast interactions with the WindowServer. The heuristic depends on the fact that the focused window is usually ordered on top of the application window list. This assumption breaks with the aforementioned yabai modifications applied. As far as I know this is as good as it gets for focused window detection without using the accessibility API, but if someone has another idea, let me know.
Current function for reference:
JankyBorders/src/misc/window.h
Lines 24 to 71 in bb6ae77
The text was updated successfully, but these errors were encountered: