Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduplicat_bismark with multiple bam files require samtools on environmental variable #609

Closed
Yoonsung1203 opened this issue Aug 7, 2023 · 1 comment

Comments

@Yoonsung1203
Copy link

Yoonsung1203 commented Aug 7, 2023

Hi, I'm reporting a simple issue on deduplicate_bismark.

There's a "--samtools_path" option to specify the path to samtools while deduplicating bam file.

However, while deduplicating with multiple bam files, it doesn't use the samtools I specified, but the samtools on environmental variables.
It's written on the 157th line of deduplicate_bismark like below.

open (IN,"$samtools_path cat -h $file @filenames | samtools view -h |") or die "Unable to read from BAM files in '@filenames': $!\n";

I think it must be changed into like this.

open (IN,"$samtools_path cat -h $file @filenames | $samtools_path view -h |") or die "Unable to read from BAM files in '@filenames': $!\n";

Thank you.

@FelixKrueger
Copy link
Owner

Good catch. I have just changed this in the dev version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants