Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix min_by/max_by(x, y, n) (facebookincubator#8566)
Summary: Pull Request resolved: facebookincubator#8566 Same as bug in min/max(x, n) fixed in facebookincubator#8311, min_by/max_by(x, y, n) also breaks the assumption of incremental window aggregation because their extractValues() methods has a side effect of clearing the accumulator. This diff fixes this issue by making the extractValues() methods of min_by/max_by(x, y, n) not clear the accumulators. Since Presto's min_by/max_by have the same bug (prestodb/presto#21653). This fix will make Velox's min_by/max_by behave differently from Presto when used in Window operation, until prestodb/presto#21653 is fixed. This diff fixes facebookincubator#8138. Reviewed By: bikramSingh91 Differential Revision: D53139892 fbshipit-source-id: 1323f22196e22554c0d880d20584a4ee4059b64c
- Loading branch information