Fix for issue #52 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running Doxypypy on a Windows machine, getLines() creates an array of strings separated by '\r\n' while technically correct, when this list is passed to the print() function, is converts the '\n' to a '\r\r\n' sequence causing issues with Doxygen on Windows and text editors in general. By changing the value passed to join() from linesep to '\n', print() properly converts the line feeds to on all platforms.
Found a better solution which allows all unit tests to pass.
|
Changed the code so print processes each line separately. This was tested with the unit tests, Windows, Mac and Linux systems. |
|
Thanks for the fix (and for running it through the tests to ensure nothing got broken). |
|
Any time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Doxypypy on a Windows machine, getLines() creates an array of strings separated by '\r\n' while technically correct, when this list is passed to the print() function, it converts the '\n' to a '\r\r\n' sequence causing issues with Doxygen on Windows and text editors in general. By changing the value passed to join() from linesep to '\n', print() properly converts the line feeds to on all platforms.