Do not match string prefix at end of docstring #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original docstring regex removed sequences such as `r"""` from a docstring regardless if it appeared at the beginning or at the end of the docstring: `r"""Simulator"""` erroneously becomes `Simulato`. However, `r` etc. are [string prefixes](https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals) and do not appear at the end of a string. Therefore, this commit changes the regex to match string prefixes only at the beginning of the docstring and not at the end. (Closes Feneric#84)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original docstring regex removed sequences such as
r"""from a docstring regardless if it appeared at the beginning or at the end of the docstring:r"""Simulator"""erroneously becomesSimulato. However,retc. are string prefixes and do not appear at the end of a string.Therefore, this commit changes the regex to match string prefixes only at the beginning of the docstring and not at the end.
(Closes #84)