Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force installation of static libgamemodeauto #378

Merged
merged 3 commits into from Oct 4, 2022
Merged

Don't force installation of static libgamemodeauto #378

merged 3 commits into from Oct 4, 2022

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Aug 6, 2022

Defining the library with library rather than both_libraries allows the user to choose which type they want to install using -Ddefault_library.

Closes: #287

@stephanlachnit
Copy link
Contributor

stephanlachnit commented Aug 31, 2022

Can you please test that when running default_library= both and default_library=static libgamemode is always only a shared library and only libgamemodeauto is affected? Even then, I think it is sensible to always build libgamemodeauto static as part of the development files. Statically linking it makes perfect sense for distributed binaries of games (and it is really really tiny, it's basically only a dynamic loader for the shared library).

Also setting default_library=static breaks gamemoderun.

@chewi
Copy link
Contributor Author

chewi commented Sep 2, 2022

I've tested and it is all as you say.

How would you like default_library=static to be handled? Don't install gamemoderun? Emit a warning about that?

@stephanlachnit
Copy link
Contributor

How would you like default_library=static to be handled? Don't install gamemoderun? Emit a warning about that?

Maybe a warning and not installing gamemoderun / building libgamemode at all?

Defining the library with `library` rather than `both_libraries` allows the user
to choose which type they want to install using `-Ddefault_library`.

Closes: #287
@chewi
Copy link
Contributor Author

chewi commented Oct 1, 2022

Done that now. Sorry for the wait.

@stephanlachnit
Copy link
Contributor

Thanks, LGTM if the CI passes (cc @afayaz-feral)

@afayaz-feral afayaz-feral merged commit 06f0193 into FeralInteractive:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ninja install installs a static library (libgamemodeauto.a) - how to resolve?
3 participants