use posix basename to fix build on musl #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc provides a nonstandard basename implementation, this can be overriden and posix basename can be used by includeing libgen.h, however musl only has posix basename, and must always include libgen.h In this particular case, it doesn't appear that using the posix version of basename will cause any issues, as it is simply being used to match a hardcoded config file name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the build failed with musl and gcc 13.2
glibc provides a nonstandard basename implementation, this can be overriden and posix basename can be used by including libgen.h, however musl only has posix basename, and must always include libgen.h
In this particular case, it doesn't appear that using the posix version of basename will cause any issues, as it is simply being used to match a hardcoded config file name.
This is probably safe, since musl has been always been using posix basename without issues, but some further testing with glibc might be needed