Skip to content

Commit

Permalink
fix: FLUI-63 code owners et pr template
Browse files Browse the repository at this point in the history
  • Loading branch information
francisl committed Jun 2, 2023
1 parent 796b63a commit 7922a8a
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 21 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@francisl @claudia1296 @atoulous @lflangis
@lflangis @francisl @claudia1296 @ethienneroy @AltefrohneGaelle @atoulous
24 changes: 16 additions & 8 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,32 @@
# [BUG | FEATURE | DOC] [TITLE]
# FIX | FEAT | REFACTOR | PERF | DOCS : TITLE

- closes #3242
- closes #TICKET_NUMBER

## Description

Acceptance Criterias
[JIRA LINK]

## Validation de Qualité
Acceptance Criterias

## Validation

- [ ] Validation du design avec design figma (dev)
- [ ] QA - Validation des critère de succès (via screenshot)
- [ ] Design/UI - Validation du respect du design/theme
- [ ] Storybook add or modified
- [ ] version Update in package.json and Release.md
- [ ] Code Approved
- [ ] QA Done
- [ ] Design/UI Approved from design

## Screenshot
### Before

### After

## QA

Steps to validate
Url (storybook, ...)
...

## Mention
@luclemo @kstonge

@kstonge @luclemo
25 changes: 13 additions & 12 deletions packages/ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,42 +62,43 @@ npm start

### Publish new release

On your PR, make sure to increment the version in packge.json
#### Merging new changes

To publish a new release once a PR as been validated and merged
1. update the version of the package in package.json (https://semver.org)
2. Update the `Release.md` file with the changes
3. Add or modify storybook that matches your changes
4. Create a PR

#### Publish
1. Try to install the package to make sure everything work corretly

> cd [test dir] && npm i [full_path]/ferlab-ui/packages/ui
2. Delete core folder to remove deleted files

> rm -rf core/
3. Prepare the package

> npm run build
4. Push the new version
5. Create a tag to the new version `git tag ui@[semantic version]`
e.g.

> git tag ui@4.4.1
> git push --tags
6. Login to npm

> npm login
7. Push the new version

> npm publish
## Styles and themes

> npm publish

## Development

Run `npx tscp -w` to live-watch sass file.



## Styles and themes
### Strategy

1. Use .less to customize colors and ant design components
Expand Down

0 comments on commit 7922a8a

Please sign in to comment.