Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resizableGrid): SKFP-698 add download graph data #285

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

lflangis
Copy link
Contributor

@lflangis lflangis commented Jun 1, 2023

FEATURE

Description

Implement the download by png, svg through a preview modal that will include the chart values and legend. In the modal, the user will have a preview of the chart and will be able to confirm and proceed to the download for the specific file format (PNG, SVG), or cancel and close the modal. The download data will be done directly from the chart’s dropdown and will not open a modal. (TSV) . 

- Modal title: “Download preview – Chart Title"
  Download PNG/SVG values and legend examples:
  Demographics, Participant by Data Type, Participant by Data Category, Age at Diagnosis, Studies.
    Value: Male , Count: 6769, Frequency: (50.89%) 
    e.g.,red Male 6769 (50.89%)
- For the 2 sunbursts, for now we can display simply display the image of the sunburst as it is in the Summary View including the description on the right hand side of the chart widget. 
- The download data (tsv format) would capture the Value (Sex:Male) , Count (4235) , and Frequency (% of the value over the total values) for most of the graphs in the Data Exploration.
- For the 2 sunbursts, we shouldn't be able to download tsv. Only PNG and SVG
- Download PNG/SVG File naming: kidsfirst-chart title-chart-year-month-day
  Download data File naming: kidsfirst-chart title-data-year-month-day
- The chart titles that have multiple words, it can all be set in lowercase, without any separation: ex.-participantbydatatype- 
- 

Acceptance Criterias

Validation de Qualité

  • Validation du design avec design figma (dev)
  • QA - Validation des critère de succès (via screenshot)
  • Design/UI - Validation du respect du design/theme

Screenshot

image
image
image
image
image
image
image
image

https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/519b1b64-86dc-4d1c-9bae-47b17eb96d85
https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/86b00dee-573c-46bd-9812-7b0325cb7d6e
https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/b24cc69c-b135-4b25-997b-570fa44b2d6d

Mention

@luclemo @kstonge

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Coverage report for packages/ui

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from e1d2d90

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Project Coverage and Test

Statements : 29.57% ( 3566/12056 )
Branches : 51.63% ( 253/490 )
Functions : 25.97% ( 80/308 )
Lines : 29.57% ( 3566/12056 )

Test Suites: 21 passed, 21 total
Tests: 92 passed, 92 total
Snapshots: 0 total
Time: 73.773 s
Ran all test suites.

@kstonge
Copy link
Member

kstonge commented Jun 1, 2023

Typo
Le titre de la modal de download devrait être “Download preview – Chart Title" avec un "p" minuscule pour "preview".

@lflangis lflangis force-pushed the feat/SKFP-698/summary-download branch from bc537c9 to 6fc9887 Compare June 2, 2023 12:29
@lflangis
Copy link
Contributor Author

lflangis commented Jun 2, 2023

J'ai corrigé la typo

De plus, @luclemo , j'avais ajouté le type d'élément qu'on allait télécharger (.svg ou .png). Est-ce que je garde le type? Je trouve que ça permet de savoir quel type on va télécharger
image

@lflangis lflangis force-pushed the feat/SKFP-698/summary-download branch from 6fc9887 to e1d2d90 Compare June 2, 2023 12:58
@lflangis lflangis merged commit 48c8d64 into master Jun 2, 2023
4 checks passed
@lflangis lflangis deleted the feat/SKFP-698/summary-download branch June 2, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants