removing logic from leaf component (ThoughtComponent)

Fernandomn · Dec 27, 2023 · f2fdc0c · f2fdc0c
1 parent 681e11c
commit f2fdc0c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/app/components/thoughts/list-thoughts/list-thoughts.component.ts b/src/app/components/thoughts/list-thoughts/list-thoughts.component.ts
@@ -69,9 +69,11 @@ export class ListThoughtsComponent implements OnInit, OnDestroy {
   }
 
   onFavoriteUpdated(thought: Thought): void {
-    if (this.isListingFavorites && !thought.favorite) {
-      this.listThoughts.splice(this.listThoughts.indexOf(thought), 1);
-    }
+    this.thoughtService.updateFavoriteThought(thought).subscribe(() => {
+      if (this.isListingFavorites && !thought.favorite) {
+        this.listThoughts.splice(this.listThoughts.indexOf(thought), 1);
+      }
+    });
   }
 
   private resetSearch() {

diff --git a/src/app/components/thoughts/thought/thought.component.ts b/src/app/components/thoughts/thought/thought.component.ts
@@ -1,6 +1,5 @@
 import { Component, EventEmitter, Input, Output } from '@angular/core';
 import { Thought } from 'src/app/interfaces/thoughts';
-import { ThoughtsService } from 'src/app/services/thoughts.service';
 
 @Component({
   selector: 'app-thought',
@@ -18,7 +17,7 @@ export class ThoughtComponent {
 
   @Output() favoriteUpdated = new EventEmitter();
 
-  constructor(private thoughtService: ThoughtsService) {}
+  constructor() {}
 
   thoughtLength(): string {
     return this.thought.content && this.thought.content.length >= 256
@@ -31,8 +30,6 @@ export class ThoughtComponent {
   }
 
   updateFavorite(): void {
-    this.thoughtService
-      .updateFavoriteThought(this.thought)
-      .subscribe(() => this.favoriteUpdated.emit(this.thought));
+    this.favoriteUpdated.emit(this.thought);
   }
 }