Skip to content

Commit

Permalink
vdpau: revert some left overs related to dropping from previous design
Browse files Browse the repository at this point in the history
  • Loading branch information
FernetMenta committed Mar 26, 2012
1 parent 18fa951 commit ea930ab
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 37 deletions.
20 changes: 3 additions & 17 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecFFmpeg.cpp
Expand Up @@ -357,29 +357,15 @@ void CDVDVideoCodecFFmpeg::SetDropState(bool bDrop)
// 2 seem to be to high.. it causes video to be ruined on following images
if( bDrop )
{
if (m_pHardware && m_pHardware->AllowFrameDropping())
{
m_pHardware->SetDropState(true);
}
else
{
// TODO: 'hurry_up' has been deprecated in favor of the skip_* variables
// Use those instead.

//m_pCodecContext->hurry_up = 1;
m_pCodecContext->skip_frame = AVDISCARD_NONREF;
m_pCodecContext->skip_idct = AVDISCARD_NONREF;
m_pCodecContext->skip_loop_filter = AVDISCARD_NONREF;
}
m_pCodecContext->skip_frame = AVDISCARD_NONREF;
m_pCodecContext->skip_idct = AVDISCARD_NONREF;
m_pCodecContext->skip_loop_filter = AVDISCARD_NONREF;
}
else
{
m_pCodecContext->skip_frame = AVDISCARD_DEFAULT;
m_pCodecContext->skip_idct = AVDISCARD_DEFAULT;
m_pCodecContext->skip_loop_filter = AVDISCARD_DEFAULT;

if (m_pHardware)
m_pHardware->SetDropState(false);
}
}
}
Expand Down
5 changes: 0 additions & 5 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecFFmpeg.h
Expand Up @@ -46,11 +46,6 @@ class CDVDVideoCodecFFmpeg : public CDVDVideoCodec
virtual void Reset () {}
virtual const std::string Name() = 0;
virtual CCriticalSection* Section() { return NULL; }

// signal to vdpau (mixer) whether we run normal speed or not
// so it can switch off deinterlacing
virtual bool AllowFrameDropping() {return true;};
virtual void SetDropState(bool bDrop) {return;};
};

CDVDVideoCodecFFmpeg();
Expand Down
13 changes: 0 additions & 13 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.cpp
Expand Up @@ -1035,24 +1035,11 @@ void CDecoder::Reset()
}
}

bool CDecoder::AllowFrameDropping()
{
// if (m_bVdpauDeinterlacing && m_dropCount < 5)
// return false;
// else
// return true;
}

void CDecoder::ReturnRenderPicture(CVdpauRenderPicture *renderPic)
{
m_vdpauOutput.m_dataPort.SendOutMessage(COutputDataProtocol::RETURNPIC, &renderPic, sizeof(renderPic));
}

void CDecoder::SetDropState(bool bDrop)
{
m_dropState = bDrop;
}

bool CDecoder::CheckStatus(VdpStatus vdp_st, int line)
{
if (vdp_st != VDP_STATUS_OK)
Expand Down
2 changes: 0 additions & 2 deletions xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.h
Expand Up @@ -527,8 +527,6 @@ class CDecoder
virtual void Reset();
virtual void Close();
virtual long Release();
virtual bool AllowFrameDropping();
virtual void SetDropState(bool bDrop);

virtual int Check(AVCodecContext* avctx);
virtual const std::string Name() { return "vdpau"; }
Expand Down

0 comments on commit ea930ab

Please sign in to comment.