VAAPI / VDPAU: Add deinterlacing methods to processInfo #404
Conversation
|
The VDPAU commit is not tested (no hardware). |
fritsch
changed the title
|
vdpau is not a mess at all. it served as a template for vaapi |
|
Yeah - it depends on how or who looks at it. VAAPI is much more clean with the PreInit methods that are properly used for hw enumeration and stuff. Never the less I found a way in vdpau to also do it at the hopefully right position. |
|
VAAPI: |
| @@ -1875,6 +1875,12 @@ bool COutput::Init() | |||
| m_pp->PreInit(m_config, &m_diMethods); | |||
| delete m_pp; | |||
|
|
|||
| std::list<EINTERLACEMETHOD> deintMethods; | |||
| deintMethods.assign(m_diMethods.diMethods, m_diMethods.diMethods + m_diMethods.numDiMethods); | |||
| deintMethods.push_back(VS_INTERLACEMETHOD_AUTO); | |||
There was a problem hiding this comment.
auto is no deinterling mode and is not automatic either. hence crap.
should be handled similar to sw decoder. if mode is not supportd by vaapi, select default.
make sure to add mode none.
fritsch
force-pushed
the
deint
branch
2 times, most recently
from
819977e
to
3c2a741
Compare
|
Looks good on Intel, all deinterlace modes avilable in Video Settings and appearing in Player Process Info dialog when selected. However, nvidia (VDPAU) doesn't have any deinterlace option available in Video Settings: |
|
Latest version of this PR seems to be working great now @fritsch. The deinterlace options are available in Video Settings for both VAAPI and VDPAU, and all the correct deinterlace descriptions are appearing in Player Process Info. Thanks! |
| @@ -2450,6 +2486,9 @@ void CMixer::InitCycle() | |||
|
|
|||
| m_processPicture.DVDPic = m_mixerInput[1].DVDPic; | |||
| m_processPicture.videoSurface = m_mixerInput[1].videoSurface; | |||
|
|
|||
| // update deinterlacing method used in processInfo (none if progressive) | |||
| m_config.processInfo->SetVideoDeintMethod(deintStr); | |||
There was a problem hiding this comment.
this should not be updated on every cycle, only when changed
There was a problem hiding this comment.
You prefer a member tracking it or can I base on m_Deint? e.g. at the beginning of this method before calling SetDeinterlacing if (method != m_Deint) -> update?
There was a problem hiding this comment.
there is a method SetDeinterlacing(). why don't you set it there?
There was a problem hiding this comment.
but still set it in InitCycle
There was a problem hiding this comment.
you still call m_config.processInfo->SetVideoDeintMethod in InitCycle, which is wrong
There was a problem hiding this comment.
Ups. Leftover. Something for tonight.
Am 29.08.2016 5:46 nachm. schrieb "Rainer Hochecker" <
notifications@github.com>:
In xbmc/cores/VideoPlayer/DVDCodecs/Video/VDPAU.cpp
#404 (comment):@@ -2450,6 +2486,9 @@ void CMixer::InitCycle()
m_processPicture.DVDPic = m_mixerInput[1].DVDPic;
m_processPicture.videoSurface = m_mixerInput[1].videoSurface;
+
- // update deinterlacing method used in processInfo (none if progressive)
- m_config.processInfo->SetVideoDeintMethod(deintStr);
you still call m_config.processInfo->SetVideoDeintMethod in InitCycle,
which is wrong—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FernetMenta/xbmc/pull/404/files/9b3f4db0ce2a8efa2228def0dd191ba5c5e80e9e#r76631096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCfHVN-318HrsmHP-VPrmA6oRo3Xv3gks5qkv7jgaJpZM4JteUI
.
RBP: Add Pi specific deinterlace support reporting
v1: Initial v2: add Auto mode v3: Remove auto again - it's "crap"
v1: Initial v2: Add Auto Mode and VDPAU_BOB v3: Fallback v4: Don't spam processInfo
|
I cherry-picked the vdpau commit and squashed further changes into it. thanks. |
See topic.
VDPAU is a mess :-) concerning its capabilities.