Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
AlekSi committed Jan 29, 2022
1 parent 8d24e59 commit 1249677
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
# It also has minimal permissions.
# * We publish Docker images from PRs as a separate package that should not be run by users.
# * We limit what third-party actions can be used.

#
# We also tried a different approach: build Docker image in one normal, secure `pull_request` workflow,
# upload artifact, and the download and publish in another workflow that has access to secrets, but treats
# upload artifact, and then download and publish it in another workflow that has access to secrets, but treats
# artifact as passive data. We use buildx for building multi-platform images, and there is a way to export
# multi-platform OCI tarball: https://docs.docker.com/engine/reference/commandline/buildx_build/#output
# Unfortunately, it seems that there is no way to import that tarball in another workflow and publish it
# as a Docker image, as strange as it sounds: https://github.com/docker/buildx/issues/186

#
# Relevant GitHub documentation is scattered. The first article gives a good overview:
# * https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
# * https://docs.github.com/en/actions/security-guides/automatic-token-authentication
Expand Down

0 comments on commit 1249677

Please sign in to comment.