Implement Collection.Compact for SQLite (#3536)

Closes #3469.
FerretDB · Oct 11, 2023 · 2d57d3f · 2d57d3f
1 parent 57e283c
commit 2d57d3f
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/internal/backends/collection_test.go b/internal/backends/collection_test.go
@@ -223,7 +223,6 @@ func TestCollectionStats(t *testing.T) {
 
 func TestCollectionCompact(t *testing.T) {
 	t.Skip("https://github.com/FerretDB/FerretDB/issues/3484")
-	t.Skip("https://github.com/FerretDB/FerretDB/issues/3469")
 
 	t.Parallel()
 

diff --git a/internal/backends/sqlite/collection.go b/internal/backends/sqlite/collection.go
@@ -331,7 +331,33 @@ func (c *collection) Stats(ctx context.Context, params *backends.CollectionStats
 
 // Compact implements backends.Collection interface.
 func (c *collection) Compact(ctx context.Context, params *backends.CompactParams) (*backends.CompactResult, error) {
-	// TODO https://github.com/FerretDB/FerretDB/issues/3469
+	var err error
+	q := `PRAGMA incremental_vacuum`
+
+	db := c.r.DatabaseGetExisting(ctx, c.dbName)
+	if db == nil {
+		return nil, backends.NewError(
+			backends.ErrorCodeDatabaseDoesNotExist,
+			lazyerrors.Errorf("no ns %s.%s", c.dbName, c.name),
+		)
+	}
+
+	coll := c.r.CollectionGet(ctx, c.dbName, c.name)
+	if coll == nil {
+		return nil, backends.NewError(
+			backends.ErrorCodeCollectionDoesNotExist,
+			lazyerrors.Errorf("no ns %s.%s", c.dbName, c.name),
+		)
+	}
+
+	if params != nil && params.Full {
+		q = `VACUUM`
+	}
+
+	if _, err = db.ExecContext(ctx, q); err != nil {
+		return nil, lazyerrors.Error(err)
+	}
+
 	return new(backends.CompactResult), nil
 }