Move getParameter tests (#450)

Refs #417.
FerretDB · Apr 6, 2022 · 5db705e · 5db705e
1 parent e95eb88
commit 5db705e
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 17 deletions.
diff --git a/integration/basic_test.go b/integration/basic_test.go
@@ -74,7 +74,6 @@ func TestInsertFind(t *testing.T) {
 		docs = append(docs, provider.Docs()...)
 	}
 
-	opts := options.Find().SetSort(bson.D{{"_id", 1}})
 	for _, expected := range docs {
 		expected := expected
 		id := expected.Map()["_id"]
@@ -83,7 +82,7 @@ func TestInsertFind(t *testing.T) {
 			t.Parallel()
 
 			var actual []bson.D
-			cursor, err := collection.Find(ctx, bson.D{{"_id", id}}, opts)
+			cursor, err := collection.Find(ctx, bson.D{{"_id", id}}, options.Find().SetSort(bson.D{{"_id", 1}}))
 			require.NoError(t, err)
 
 			err = cursor.All(ctx, &actual)

diff --git a/integration/commands_administration_test.go b/integration/commands_administration_test.go
@@ -72,3 +72,23 @@ func TestCommandsAdministrationCreateDropList(t *testing.T) {
 	require.NoError(t, err)
 	assert.Contains(t, names, name)
 }
+
+func TestCommandsAdministrationGetParameter(t *testing.T) {
+	t.Parallel()
+	ctx, collection := setupWithOpts(t, &setupOpts{
+		databaseName: "admin",
+	})
+
+	var actual bson.D
+	err := collection.Database().RunCommand(ctx, bson.D{{"getParameter", "*"}}).Decode(&actual)
+	require.NoError(t, err)
+
+	m := actual.Map()
+	t.Log(m)
+
+	assert.Equal(t, 1.0, m["ok"])
+
+	keys := collectKeys(t, actual)
+	assert.Contains(t, keys, "quiet")
+	assert.Equal(t, false, m["quiet"])
+}
diff --git a/integration/query_array_test.go b/integration/query_array_test.go
@@ -31,8 +31,8 @@ func TestQueryArraySize(t *testing.T) {
 	_, err := collection.InsertMany(ctx, []any{
 		bson.D{{"_id", "array-empty"}, {"value", bson.A{}}},
 		bson.D{{"_id", "array-one"}, {"value", bson.A{"1"}}},
-		bson.D{{"_id", "array-two"}, {"value", bson.A{"1", "2"}}},
-		bson.D{{"_id", "array-three"}, {"value", bson.A{"1", "2", "3"}}},
+		bson.D{{"_id", "array-two"}, {"value", bson.A{"1", nil}}},
+		bson.D{{"_id", "array-three"}, {"value", bson.A{"1", "2", math.NaN()}}},
 		bson.D{{"_id", "string"}, {"value", "12"}},
 		bson.D{{"_id", "document"}, {"value", bson.D{{"value", bson.A{"1", "2"}}}}},
 	})

diff --git a/integration/query_bitwise_test.go b/integration/query_bitwise_test.go
@@ -30,7 +30,6 @@ func TestQueryBitwiseAllClear(t *testing.T) {
 	t.Parallel()
 	ctx, collection := setup(t, shareddata.Scalars)
 
-	opts := options.Find().SetSort(bson.D{{"_id", 1}})
 	for name, tc := range map[string]struct {
 		v           any
 		expectedIDs []any
@@ -50,7 +49,7 @@ func TestQueryBitwiseAllClear(t *testing.T) {
 
 			var actual []bson.D
 			q := bson.D{{"value", bson.D{{"$bitsAllClear", tc.v}}}}
-			cursor, err := collection.Find(ctx, q, opts)
+			cursor, err := collection.Find(ctx, q, options.Find().SetSort(bson.D{{"_id", 1}}))
 			if tc.err != nil {
 				require.Nil(t, tc.expectedIDs)
 				require.Equal(t, tc.err, err)

diff --git a/internal/handlers/handler_test.go b/internal/handlers/handler_test.go
@@ -1505,16 +1505,6 @@ func TestReadOnlyHandlers(t *testing.T) {
 			},
 		},
 
-		"GetParameter": {
-			req: types.MustNewDocument(
-				"getParameter", int32(1),
-			),
-			resp: types.MustNewDocument(
-				"version", "5.0.42",
-				"ok", float64(1),
-			),
-		},
-
 		"ServerStatus": {
 			req: must.NotFail(types.NewDocument(
 				"serverStatus", int32(1),

diff --git a/internal/handlers/pg/msg_getparameter.go b/internal/handlers/pg/msg_getparameter.go
@@ -30,12 +30,14 @@ func (h *Handler) MsgGetParameter(ctx context.Context, msg *wire.OpMsg) (*wire.O
 		return nil, lazyerrors.Error(err)
 	}
 
+	// TODO https://github.com/FerretDB/FerretDB/issues/449
+
 	common.Ignored(document, h.l, "comment")
 
 	var reply wire.OpMsg
 	err = reply.SetSections(wire.OpMsgSection{
 		Documents: []*types.Document{types.MustNewDocument(
-			"version", versionValue,
+			"quiet", false,
 			"ok", float64(1),
 		)},
 	})