Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find command should support skip argument #1445

Closed
3 tasks done
Tracked by #1773 ...
b1ron opened this issue Nov 16, 2022 · 0 comments · Fixed by #2193
Closed
3 tasks done
Tracked by #1773 ...

find command should support skip argument #1445

b1ron opened this issue Nov 16, 2022 · 0 comments · Fixed by #2193
Assignees
Labels
code/enhancement Some user-visible feature could work better
Milestone

Comments

@b1ron
Copy link
Contributor

b1ron commented Nov 16, 2022

What should be done?

We should support skip parameter for find and count commands. Do that only for the PostgreSQL handler.

Compat test cases should be extended to include skipDocs int field and use it. (We will rename the existing skip string that is used for skipping tests later).

We don't push down sorting, so that issue should be straightforward.

Where?

https://github.com/FerretDB/FerretDB/blob/main/internal/handlers/pg/msg_find.go
https://github.com/FerretDB/FerretDB/blob/main/internal/handlers/pg/msg_count.go

Definition of Done

  • PostgreSQL handler updated;
  • compatibility tests updated;
  • spot refactorings done;
  • user documentation updated.

test cases

  • negative numbers
  • non integers
  • etc
@b1ron b1ron added the code/enhancement Some user-visible feature could work better label Nov 16, 2022
@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 13, 2023
@rumyantseva rumyantseva self-assigned this Mar 13, 2023
rumyantseva added a commit that referenced this issue Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants