New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework integration test setup and auth #1568
Closed
9 of 11 tasks
Labels
code/chore
Code maintenance improvements
not ready
Issues that are not ready to be worked on; PRs that should skip CI
Comments
AlekSi
changed the title
Integration test setup is not correct for Tigris
Rework integration test setup for Tigris and auth
Dec 30, 2022
9 tasks
rumyantseva
added
not ready
Issues that are not ready to be worked on; PRs that should skip CI
and removed
not ready
Issues that are not ready to be worked on; PRs that should skip CI
labels
Jan 6, 2023
This was referenced Jan 24, 2023
This was referenced Jan 27, 2023
9 tasks
AlekSi
pushed a commit
that referenced
this issue
Feb 1, 2023
I will check what else we could do |
I will check if we could do something more useful |
AlekSi
added
the
not ready
Issues that are not ready to be worked on; PRs that should skip CI
label
May 1, 2023
AlekSi
changed the title
Rework integration test setup for Tigris and auth
Rework integration test setup and auth
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code/chore
Code maintenance improvements
not ready
Issues that are not ready to be worked on; PRs that should skip CI
What should be done?
At the moment, we fetch flag values but each test can't assign value for the flag. Additionally
-handler
flag is used incorrectly for validator.tigris
handler for both databases and then ignore MongoDB's error. In general,-handler
's flag value is used incorrectly.FerretDB/integration/setup/setup_compat.go
Line 131 in f0ca781
FerretDB/integration/setup/common.go
Line 231 in f0ca781
TestEnvData
.postgresql-url
inTestCommandsAuthenticationSASLStart
FerretDB/integration/shareddata/shareddata.go
Lines 33 to 39 in 62039bf
FerretDB/integration/setup/common.go
Lines 170 to 181 in cc7b47d
FerretDB/integration/create_test.go
Lines 70 to 81 in 56a2dd1
Keep note that maybe we may want test data per provider.
Where?
See references to this issue in code.
DoD:
TestCommandsAuthenticationSASLStart
task env-data
(Fixenv-data
Taskfile target #2200)The text was updated successfully, but these errors were encountered: