Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pgx/v5 #1717

Closed
Tracked by #6
AlekSi opened this issue Dec 29, 2022 · 5 comments · Fixed by #2439
Closed
Tracked by #6

Migrate to pgx/v5 #1717

AlekSi opened this issue Dec 29, 2022 · 5 comments · Fixed by #2439
Assignees
@AlekSi @craigpastro
Labels
code/chore Code maintenance improvements deps PRs that update dependencies
Milestone
v1.1.0

Comments

@AlekSi
Copy link
Member

AlekSi commented Dec 29, 2022 •
edited

What should be done?

We should migrate to github.com/jackc/pgx/v5 to stay current.
See https://github.com/jackc/pgx/blob/master/CHANGELOG.md

Where?

Everywhere.

Definition of Done

  • github.com/jackc/pgx/v4, github.com/jackc/pgtype, github.com/jackc/pgconn, and github.com/jackc/pgproto3 packages should not be present in any go.mod files.
  • Those old packages should be added to depguard linter configuration.
@AlekSi AlekSi added deps PRs that update dependencies code/chore Code maintenance improvements labels Dec 29, 2022
@AlekSi AlekSi mentioned this issue Jan 25, 2023
Open
This was referenced Apr 7, 2023
Closed
Open
@craigpastro
Copy link
Contributor

I can probably handle this! Mind if I give it a shot?

@AlekSi AlekSi added this to the v1.1.0 milestone Apr 16, 2023
@AlekSi
Copy link
Member Author

AlekSi commented Apr 16, 2023

@craigpastro Sure!

@craigpastro craigpastro mentioned this issue Apr 16, 2023
Merged
9 tasks
@AlekSi
Copy link
Member Author

AlekSi commented Apr 17, 2023

@craigpastro would you be interested in #2389?

AlekSi pushed a commit that referenced this issue Apr 17, 2023
Migrate to pgx/v5 (#2439)
d7e609c 
Closes #1717.
@craigpastro
Copy link
Contributor

Hi @AlekSi. Sure, I can take a shot at tackling #2389. Thanks!

@AlekSi
Copy link
Member Author

AlekSi commented Apr 17, 2023

@craigpastro please leave a comment on that issue so I could assign it to you. I guess GitHub doesn't allow that without interaction to prevent spam

fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 17, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
0656ccf 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
a9673ed 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
efcc60d 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
c7336c7 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this issue Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
d503d04 
Closes FerretDB#1717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlekSi AlekSi

@craigpastro craigpastro

Labels
code/chore Code maintenance improvements deps PRs that update dependencies
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Migrate to pgx/v5
2 participants
@AlekSi @craigpastro